src/conversions-inl.h - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions-inl.h

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/conversions-inl.h

diff --git a/src/conversions-inl.h b/src/conversions-inl.h

index 7edaf224072124437cab688b59bf36302bd066a2..eb718d684dfa4de811f93e6d4ae62329705a59c8 100644

--- a/src/conversions-inl.h

+++ b/src/conversions-inl.h

@@ -77,7 +77,7 @@ inline unsigned int FastD2UI(double x) {

uint32_t result;

Address mantissa_ptr = reinterpret_cast<Address>(&x);

// Copy least significant 32 bits of mantissa.

- memcpy(&result, mantissa_ptr, sizeof(result));

+ OS::MemCopy(&result, mantissa_ptr, sizeof(result));

return negative ? ~result + 1 : result;

}

// Large number (outside uint32 range), Infinity or NaN.

« no previous file with comments | « src/builtins.cc ('k') | src/debug.cc » ('j') | no next file with comments »