Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Side by Side Diff: src/objects.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/simulator-mips.cc ('k') | src/platform.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 14065 matching lines...) Expand 10 before | Expand all | Expand 10 after
14076 Handle<DeclaredAccessorDescriptor> value = 14076 Handle<DeclaredAccessorDescriptor> value =
14077 isolate->factory()->NewDeclaredAccessorDescriptor(); 14077 isolate->factory()->NewDeclaredAccessorDescriptor();
14078 value->set_serialized_data(*serialized_descriptor); 14078 value->set_serialized_data(*serialized_descriptor);
14079 // Copy in the data. 14079 // Copy in the data.
14080 { 14080 {
14081 AssertNoAllocation no_allocation; 14081 AssertNoAllocation no_allocation;
14082 uint8_t* array = serialized_descriptor->GetDataStartAddress(); 14082 uint8_t* array = serialized_descriptor->GetDataStartAddress();
14083 if (previous_length != 0) { 14083 if (previous_length != 0) {
14084 uint8_t* previous_array = 14084 uint8_t* previous_array =
14085 previous->serialized_data()->GetDataStartAddress(); 14085 previous->serialized_data()->GetDataStartAddress();
14086 memcpy(array, previous_array, previous_length); 14086 OS::MemCopy(array, previous_array, previous_length);
14087 array += previous_length; 14087 array += previous_length;
14088 } 14088 }
14089 ASSERT(reinterpret_cast<uintptr_t>(array) % sizeof(uintptr_t) == 0); 14089 ASSERT(reinterpret_cast<uintptr_t>(array) % sizeof(uintptr_t) == 0);
14090 DeclaredAccessorDescriptorData* data = 14090 DeclaredAccessorDescriptorData* data =
14091 reinterpret_cast<DeclaredAccessorDescriptorData*>(array); 14091 reinterpret_cast<DeclaredAccessorDescriptorData*>(array);
14092 *data = descriptor; 14092 *data = descriptor;
14093 } 14093 }
14094 return value; 14094 return value;
14095 } 14095 }
14096 14096
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
14473 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 14473 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
14474 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 14474 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
14475 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 14475 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
14476 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 14476 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
14477 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 14477 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
14478 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 14478 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
14479 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 14479 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
14480 } 14480 }
14481 14481
14482 } } // namespace v8::internal 14482 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/simulator-mips.cc ('k') | src/platform.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698