Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 StringBuilder builder(buffer, ARRAY_SIZE(buffer)); 128 StringBuilder builder(buffer, ARRAY_SIZE(buffer));
129 va_list arguments; 129 va_list arguments;
130 va_start(arguments, format); 130 va_start(arguments, format);
131 builder.AddFormattedList(format, arguments); 131 builder.AddFormattedList(format, arguments);
132 va_end(arguments); 132 va_end(arguments);
133 133
134 // Copy the string before recording it in the assembler to avoid 134 // Copy the string before recording it in the assembler to avoid
135 // issues when the stack allocated buffer goes out of scope. 135 // issues when the stack allocated buffer goes out of scope.
136 size_t length = builder.position(); 136 size_t length = builder.position();
137 Vector<char> copy = Vector<char>::New(length + 1); 137 Vector<char> copy = Vector<char>::New(length + 1);
138 memcpy(copy.start(), builder.Finalize(), copy.length()); 138 OS::MemCopy(copy.start(), builder.Finalize(), copy.length());
139 masm()->RecordComment(copy.start()); 139 masm()->RecordComment(copy.start());
140 } 140 }
141 141
142 142
143 bool LCodeGen::GeneratePrologue() { 143 bool LCodeGen::GeneratePrologue() {
144 ASSERT(is_generating()); 144 ASSERT(is_generating());
145 145
146 if (info()->IsOptimizing()) { 146 if (info()->IsOptimizing()) {
147 ProfileEntryHookStub::MaybeCallEntryHook(masm_); 147 ProfileEntryHookStub::MaybeCallEntryHook(masm_);
148 148
(...skipping 6395 matching lines...) Expand 10 before | Expand all | Expand 10 after
6544 FixedArray::kHeaderSize - kPointerSize)); 6544 FixedArray::kHeaderSize - kPointerSize));
6545 __ bind(&done); 6545 __ bind(&done);
6546 } 6546 }
6547 6547
6548 6548
6549 #undef __ 6549 #undef __
6550 6550
6551 } } // namespace v8::internal 6551 } } // namespace v8::internal
6552 6552
6553 #endif // V8_TARGET_ARCH_IA32 6553 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698