Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/atomicops_internals_x86_gcc.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 13 matching lines...) Expand all
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // This module gets enough CPU information to optimize the 28 // This module gets enough CPU information to optimize the
29 // atomicops module on x86. 29 // atomicops module on x86.
30 30
31 #include <string.h> 31 #include <string.h>
32 32
33 #include "atomicops.h" 33 #include "atomicops.h"
34 #include "platform.h"
34 35
35 // This file only makes sense with atomicops_internals_x86_gcc.h -- it 36 // This file only makes sense with atomicops_internals_x86_gcc.h -- it
36 // depends on structs that are defined in that file. If atomicops.h 37 // depends on structs that are defined in that file. If atomicops.h
37 // doesn't sub-include that file, then we aren't needed, and shouldn't 38 // doesn't sub-include that file, then we aren't needed, and shouldn't
38 // try to do anything. 39 // try to do anything.
39 #ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_ 40 #ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_
40 41
41 // Inline cpuid instruction. In PIC compilations, %ebx contains the address 42 // Inline cpuid instruction. In PIC compilations, %ebx contains the address
42 // of the global offset table. To avoid breaking such executables, this code 43 // of the global offset table. To avoid breaking such executables, this code
43 // must preserve that register's value across cpuid instructions. 44 // must preserve that register's value across cpuid instructions.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 using v8::internal::AtomicOps_Internalx86CPUFeatures; 78 using v8::internal::AtomicOps_Internalx86CPUFeatures;
78 79
79 uint32_t eax; 80 uint32_t eax;
80 uint32_t ebx; 81 uint32_t ebx;
81 uint32_t ecx; 82 uint32_t ecx;
82 uint32_t edx; 83 uint32_t edx;
83 84
84 // Get vendor string (issue CPUID with eax = 0) 85 // Get vendor string (issue CPUID with eax = 0)
85 cpuid(eax, ebx, ecx, edx, 0); 86 cpuid(eax, ebx, ecx, edx, 0);
86 char vendor[13]; 87 char vendor[13];
87 memcpy(vendor, &ebx, 4); 88 v8::internal::OS::MemCopy(vendor, &ebx, 4);
88 memcpy(vendor + 4, &edx, 4); 89 v8::internal::OS::MemCopy(vendor + 4, &edx, 4);
89 memcpy(vendor + 8, &ecx, 4); 90 v8::internal::OS::MemCopy(vendor + 8, &ecx, 4);
90 vendor[12] = 0; 91 vendor[12] = 0;
91 92
92 // get feature flags in ecx/edx, and family/model in eax 93 // get feature flags in ecx/edx, and family/model in eax
93 cpuid(eax, ebx, ecx, edx, 1); 94 cpuid(eax, ebx, ecx, edx, 1);
94 95
95 int family = (eax >> 8) & 0xf; // family and model fields 96 int family = (eax >> 8) & 0xf; // family and model fields
96 int model = (eax >> 4) & 0xf; 97 int model = (eax >> 4) & 0xf;
97 if (family == 0xf) { // use extended family and model fields 98 if (family == 0xf) { // use extended family and model fields
98 family += (eax >> 20) & 0xff; 99 family += (eax >> 20) & 0xff;
99 model += ((eax >> 16) & 0xf) << 4; 100 model += ((eax >> 16) & 0xf) << 4;
(...skipping 24 matching lines...) Expand all
124 }; 125 };
125 126
126 // A global to get use initialized on startup via static initialization :/ 127 // A global to get use initialized on startup via static initialization :/
127 AtomicOpsx86Initializer g_initer; 128 AtomicOpsx86Initializer g_initer;
128 129
129 } // namespace 130 } // namespace
130 131
131 #endif // if x86 132 #endif // if x86
132 133
133 #endif // ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_ 134 #endif // ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_
OLDNEW
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698