Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 1393193005: Implement $Secure- cookie prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_api.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc
index 8f020919d9ee61dab4fc592f87ab4dad426de9de..558f90d868e672ee144e3fc4fb71603aac22d5a3 100644
--- a/chrome/browser/extensions/api/cookies/cookies_api.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc
@@ -382,9 +382,8 @@ void CookiesSetFunction::SetCookieOnIOThread() {
}
cookie_monster->SetCookieWithDetailsAsync(
- url_,
- parsed_args_->details.name.get() ? *parsed_args_->details.name
- : std::string(),
+ url_, parsed_args_->details.name.get() ? *parsed_args_->details.name
+ : std::string(),
parsed_args_->details.value.get() ? *parsed_args_->details.value
: std::string(),
parsed_args_->details.domain.get() ? *parsed_args_->details.domain
@@ -399,7 +398,9 @@ void CookiesSetFunction::SetCookieOnIOThread() {
// TODO(mkwst): If we decide to ship First-party-only cookies, we'll need
// to extend the extension API to support them. For the moment, we'll set
// all cookies as non-First-party-only.
- false,
+ false, store_browser_context_->GetURLRequestContext()
+ ->network_delegate()
+ ->AreExperimentalCookieFeaturesEnabled(),
net::COOKIE_PRIORITY_DEFAULT,
base::Bind(&CookiesSetFunction::PullCookie, this));
}

Powered by Google App Engine
This is Rietveld 408576698