net/url_request/url_request_http_job.cc - Issue 1393193005: Implement $Secure- cookie prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1393193005: Implement $Secure- cookie prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mkwst comments, split out rename into separate CL Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index 378f6f942d923e7ec4b65f2ad03d3633ddf9e4fb..fa62fcf3f33d3f813c698b5be4c0e5ffc04a976c 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -749,6 +749,8 @@ void URLRequestHttpJob::SaveNextCookie() {

CookieOptions options;

options.set_include_httponly();

options.set_server_time(response_date_);

+ if (network_delegate()->ExperimentalCookieFeaturesEnabled())

+ options.set_enforce_prefixes();

CookieStore::SetCookiesCallback callback(base::Bind(

&URLRequestHttpJob::OnCookieSaved, weak_factory_.GetWeakPtr(),