Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1393193005: Implement $Secure- cookie prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add another test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index c317469cb137ad7ec840f229a7ffeb26dce62ad1..d097214c41879144f4f5c2a7e472e79fe270e9c1 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -660,8 +660,7 @@ void URLRequestHttpJob::DoLoadCookies() {
// TODO(mkwst): Drop this `if` once we decide whether or not to ship
// first-party cookies: https://crbug.com/459154
- if (network_delegate() &&
- network_delegate()->FirstPartyOnlyCookieExperimentEnabled())
+ if (network_delegate() && network_delegate()->ExperimentalFeaturesEnabled())
options.set_first_party_url(request_->first_party_for_cookies());
else
options.set_include_first_party_only();
@@ -749,6 +748,8 @@ void URLRequestHttpJob::SaveNextCookie() {
CookieOptions options;
options.set_include_httponly();
options.set_server_time(response_date_);
+ if (network_delegate()->ExperimentalFeaturesEnabled())
+ options.set_enforce_prefixes();
CookieStore::SetCookiesCallback callback(base::Bind(
&URLRequestHttpJob::OnCookieSaved, weak_factory_.GetWeakPtr(),

Powered by Google App Engine
This is Rietveld 408576698