net/base/network_delegate_impl.h - Issue 1393193005: Implement $Secure- cookie prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_delegate_impl.h

Issue 1393193005: Implement $Secure- cookie prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add another test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/network_delegate_impl.h

diff --git a/net/base/network_delegate_impl.h b/net/base/network_delegate_impl.h

index b0345dd062ad85b949416aaed431bc762d04f0ff..c81bcfd12ca696045aa4080f0e19d00cbd745956 100644

--- a/net/base/network_delegate_impl.h

+++ b/net/base/network_delegate_impl.h

@@ -210,8 +210,9 @@ class NET_EXPORT NetworkDelegateImpl : public NetworkDelegate {

// experiment, and false otherwise.

// TODO(mkwst): Remove this once we decide whether or not we wish to ship

- // first-party cookies. https://crbug.com/459154

- bool OnFirstPartyOnlyCookieExperimentEnabled() const override;

+ // first-party cookies and cookie prefixes. https://crbug.com/459154,

+ // https://crbug.com/541511

+ bool OnExperimentalFeaturesEnabled() const override;

// Called when the |referrer_url| for requesting |target_url| during handling

// of the |request| is does not comply with the referrer policy (e.g. a