Implement $Secure- cookie prefix

net/url_request/url_request_http_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 731 matching lines @@
   // OnCookieSaved.
   scoped_refptr<SharedBoolean> callback_pending = new SharedBoolean(false);
   scoped_refptr<SharedBoolean> save_next_cookie_running =
       new SharedBoolean(true);
 
   if (!(request_info_.load_flags & LOAD_DO_NOT_SAVE_COOKIES) &&
       request_->context()->cookie_store() && response_cookies_.size() > 0) {
     CookieOptions options;
     options.set_include_httponly();
     options.set_server_time(response_date_);
+    if (network_delegate()->AreExperimentalCookieFeaturesEnabled())

[droger, 2015/12/01 13:10:23]

Is it supported to have a null delegate?
I see that a lot of places test for the existence of the delegate before calling
it, but this is not done here.
See line 663 above for example.

There is some code (ios/crnet/crnet_environment) that sets up the network stack
without network delegate, and it now crashes here. Should I use a dummy delegate
there, or should we fix this call to support the null delegate?

[mmenke, 2015/12/01 15:55:53]

Hrm...we generally allow a NULL delegate.  The fact that apparently not a lot of
tests use HTTP requests with NULL delegates, so this wasn't caught indicates
that perhaps we should rethink supporting the NULL delegate case.

For now, though, this code should be fixed.

+      options.set_enforce_prefixes();
 
     CookieStore::SetCookiesCallback callback(base::Bind(
         &URLRequestHttpJob::OnCookieSaved, weak_factory_.GetWeakPtr(),
         save_next_cookie_running, callback_pending));
 
     // Loop through the cookies as long as SetCookieWithOptionsAsync completes
     // synchronously.
     while (!callback_pending->data &&
            response_cookies_save_index_ < response_cookies_.size()) {
       if (CanSetCookie(
@@ skipping 813 matching lines @@
   return override_response_headers_.get() ?
              override_response_headers_.get() :
              transaction_->GetResponseInfo()->headers.get();
 }
 
 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
   awaiting_callback_ = false;
 }
 
 }  // namespace net