Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: chrome/browser/ui/views/tabs/tab_controller.h

Issue 1393193002: Paint tab-loading throbbers into a ui::Layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simpler: TabController::CanPaintThrobberToLayer. Also: a test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_strip.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_
7 7
8 #include "chrome/browser/ui/views/tabs/tab_strip_types.h" 8 #include "chrome/browser/ui/views/tabs/tab_strip_types.h"
9 9
10 class Tab; 10 class Tab;
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 // Invoked when a mouse event occurs on |source|. 87 // Invoked when a mouse event occurs on |source|.
88 virtual void OnMouseEventInTab(views::View* source, 88 virtual void OnMouseEventInTab(views::View* source,
89 const ui::MouseEvent& event) = 0; 89 const ui::MouseEvent& event) = 0;
90 90
91 // Returns true if |tab| needs to be painted. If false is returned the tab is 91 // Returns true if |tab| needs to be painted. If false is returned the tab is
92 // not painted. If true is returned the tab should be painted and |clip| is 92 // not painted. If true is returned the tab should be painted and |clip| is
93 // set to the clip (if |clip| is empty means no clip). 93 // set to the clip (if |clip| is empty means no clip).
94 virtual bool ShouldPaintTab(const Tab* tab, gfx::Rect* clip) = 0; 94 virtual bool ShouldPaintTab(const Tab* tab, gfx::Rect* clip) = 0;
95 95
96 // Returns true if tab loading throbbers can be painted to a composited layer.
97 // This can only be done when the TabController can guarantee that nothing
98 // in the same window will redraw on top of the the favicon area of any tab.
99 virtual bool CanPaintThrobberToLayer() const = 0;
100
96 // Returns true if tabs painted in the rectangular light-bar style. 101 // Returns true if tabs painted in the rectangular light-bar style.
97 virtual bool IsImmersiveStyle() const = 0; 102 virtual bool IsImmersiveStyle() const = 0;
98 103
99 // Adds private information to the tab's accessibility state. 104 // Adds private information to the tab's accessibility state.
100 virtual void UpdateTabAccessibilityState(const Tab* tab, 105 virtual void UpdateTabAccessibilityState(const Tab* tab,
101 ui::AXViewState* state) = 0; 106 ui::AXViewState* state) = 0;
102 107
103 protected: 108 protected:
104 virtual ~TabController() {} 109 virtual ~TabController() {}
105 }; 110 };
106 111
107 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_ 112 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | chrome/browser/ui/views/tabs/tab_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698