Update app menu button MD colors for the notification case.

Update app menu button MD colors for the notification case.

(Sadly this can no longer be called the hotdog menu as it looks like a sideways ellipsis.)

BUG=505953
Committed: https://crrev.com/bd6d06424a36bb6b007687854c0ce212853ee646
Cr-Commit-Position: refs/heads/master@{#353088}

[Evan Stade, 2015-10-07 21:59:17]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-10-07 21:59:17]

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc (right):

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc:142: const int
kButtonSize = 16;
(in the future this should move to layout_constants or come from the .icon file.
Since this is one of the special icons that requires 1x specialization, the
latter would make sense.)

[Evan Stade, 2015-10-07 21:59:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-07 22:02:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393163002/1

[sky, 2015-10-07 23:41:52]

LGTM

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc (right):

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc:142: const int
kButtonSize = 16;
On 2015/10/07 21:59:17, Evan Stade wrote:
> (in the future this should move to layout_constants or come from the .icon
file.
> Since this is one of the special icons that requires 1x specialization, the
> latter would make sense.)

How about a TODO then?

https://codereview.chromium.org/1393163002/diff/1/ui/gfx/color_palette.h
File ui/gfx/color_palette.h (right):

https://codereview.chromium.org/1393163002/diff/1/ui/gfx/color_palette.h#newc...
ui/gfx/color_palette.h:15: const SkColor kGoogleRed700 = SkColorSetRGB(0xC5,
0x39, 0x29);
It's not clear to me why these have 700 in the name? The 700 club? I'm sure
there is some good reason. It's worth documenting that.

[Evan Stade, 2015-10-08 00:03:31]

also removed kAmber in favor of kGoogleYellow700 as per email from sgabriel.

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc (right):

https://codereview.chromium.org/1393163002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc:142: const int
kButtonSize = 16;
On 2015/10/07 23:41:52, sky wrote:
> On 2015/10/07 21:59:17, Evan Stade wrote:
> > (in the future this should move to layout_constants or come from the .icon
> file.
> > Since this is one of the special icons that requires 1x specialization, the
> > latter would make sense.)
> 
> How about a TODO then?

Done.

https://codereview.chromium.org/1393163002/diff/1/ui/gfx/color_palette.h
File ui/gfx/color_palette.h (right):

https://codereview.chromium.org/1393163002/diff/1/ui/gfx/color_palette.h#newc...
ui/gfx/color_palette.h:15: const SkColor kGoogleRed700 = SkColorSetRGB(0xC5,
0x39, 0x29);
On 2015/10/07 23:41:52, sky wrote:
> It's not clear to me why these have 700 in the name? The 700 club? I'm sure
> there is some good reason. It's worth documenting that.

Apparently it's an arbitrary nomenclature dreamt up for material design:
http://www.materialui.co/colors

Docs added.

[Evan Stade, 2015-10-08 00:04:28]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 00:06:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393163002/20001

[commit-bot: I haz the power, 2015-10-08 01:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 01:13:25]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2015-10-08 17:51:34]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-10-08 17:51:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1393163002/#ps20001
(title: "replace amber with yellow700")

[commit-bot: I haz the power, 2015-10-08 17:53:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393163002/20001

[commit-bot: I haz the power, 2015-10-08 18:25:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-08 18:26:35]

Patchset 2 (id:??) landed as
https://crrev.com/bd6d06424a36bb6b007687854c0ce212853ee646
Cr-Commit-Position: refs/heads/master@{#353088}