Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139313007: Deprecate HTMLVideoElement-specific prefixed fullscreen API (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
CC:
blink-reviews, arv+blink, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Deprecate HTMLVideoElement-specific prefixed fullscreen API Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/DULRMEUkeJw/9HXn55X1gj4J Unfortunately Blink doesn't support the unprefixed fullscreen API yet, so advise authors to use both the unprefixed and prefixed APIs. webkitSupportsFullscreen was found to be needlessly complicated for what it does, so a bug to simplify it was filed: http://crbug.com/334985 BUG=334987 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165288

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/video-controls-visible-exiting-fullscreen-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/video-enter-fullscreen-without-user-gesture-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/media/video-play-require-user-gesture-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
This depends on https://codereview.chromium.org/139303007/ to land first
6 years, 11 months ago (2014-01-16 09:04:08 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 11 months ago (2014-01-16 18:05:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/1
6 years, 11 months ago (2014-01-16 18:36:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17781
6 years, 11 months ago (2014-01-16 20:02:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 01:41:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17815
6 years, 11 months ago (2014-01-17 02:20:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 02:29:26 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17834
6 years, 11 months ago (2014-01-17 03:05:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 03:52:57 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17870
6 years, 11 months ago (2014-01-17 04:29:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 04:41:19 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17890
6 years, 11 months ago (2014-01-17 05:34:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 06:08:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139313007/190001
6 years, 11 months ago (2014-01-17 06:47:17 UTC) #14
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 08:17:02 UTC) #15
Message was sent while issue was closed. 
Change committed as 165288

Powered by Google App Engine
This is Rietveld 408576698