Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 139313005: Implement TracingController::GetMonitoringStatus (Closed)

Created:
6 years, 11 months ago by haraken
Modified:
6 years, 11 months ago
Reviewers:
dsinclair, nduca, Xianzhu
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam
Visibility:
Public.

Description

Implement TracingController::GetMonitoringStatus trace-viewer side CL is here: https://codereview.appspot.com/52710047 Currently the monitoring mode doesn't work correctly when we reload about:tracing. This is because reloaded about:tracing fails in extracting the current monitoring status (See my comment in patch set 2). This CL implements TracingController::GetMonitoringStatus so that trace-viewer/src/about_tracing/profiling_view.js can get the current monitoring status when loading the profiling view. TEST=content_browsertests::EnableCaptureAndDisableMonitoring R=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245211

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
M content/browser/tracing/tracing_controller_browsertest.cc View 3 chunks +44 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 6 chunks +8 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 2 7 chunks +40 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
PTAL. https://codereview.chromium.org/139313005/diff/30001/content/browser/tracing/tracing_controller_impl.cc File content/browser/tracing/tracing_controller_impl.cc (left): https://codereview.chromium.org/139313005/diff/30001/content/browser/tracing/tracing_controller_impl.cc#oldcode790 content/browser/tracing/tracing_controller_impl.cc:790: tracing_ui->OnMonitoringStateChanged(is_monitoring_); I expected that this will fire window.onMonitoringStateChanged ...
6 years, 11 months ago (2014-01-16 02:32:14 UTC) #1
nduca
lgtm
6 years, 11 months ago (2014-01-16 03:12:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/139313005/30001
6 years, 11 months ago (2014-01-16 03:17:05 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247084
6 years, 11 months ago (2014-01-16 03:39:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/139313005/30001
6 years, 11 months ago (2014-01-16 03:49:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/139313005/360001
6 years, 11 months ago (2014-01-16 05:34:20 UTC) #6
haraken
Looks like the failures in *_swarm_triggered are flakes.
6 years, 11 months ago (2014-01-16 16:12:20 UTC) #7
haraken
6 years, 11 months ago (2014-01-16 16:13:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r245211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698