Add external data use observer

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/pref_member.h"
 #include "base/strings/string_piece.h"
 #include "base/time/time.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/ssl_config_service_manager.h"
+#include "components/data_usage/core/data_use_aggregator.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/browser_thread_delegate.h"
 #include "net/base/network_change_notifier.h"
 #include "net/http/http_network_session.h"
 #include "net/socket/next_proto.h"
 
 class PrefProxyConfigTracker;
 class PrefService;
 class PrefRegistrySimple;
 class SystemURLRequestContextGetter;
 
 namespace base {
 class CommandLine;
 }
 
 namespace chrome_browser_net {
 class DnsProbeService;
 }
 
 namespace extensions {
 class EventRouterForwarder;
 }
 
-namespace data_usage {
-class DataUseAggregator;
-}
-
 namespace net {
 class CertPolicyEnforcer;
 class CertVerifier;
 class ChannelIDService;
 class CookieStore;
 class CTVerifier;
 class FtpTransactionFactory;
 class HostMappingRules;
 class HostResolver;
 class HttpAuthHandlerFactory;
@@ skipping 62 matching lines @@
      private:
       Globals* const globals_;
     };
 
     Globals();
     ~Globals();
 
     // Global aggregator of data use. It must outlive the
     // |system_network_delegate|.
     scoped_ptr<data_usage::DataUseAggregator> data_use_aggregator;
+    // An external observer of data use.
+    scoped_ptr<data_usage::DataUseAggregator::Observer>
+        external_data_use_observer;

[mmenke, 2015/10/12 16:59:26]

Actually, can this just be in IOThread?  If you need these to have one of the
properties of globals (Settable for testing, used in InitFromGlobals, exposed
publicly), that's fine, though I'd like to know which one it is.

[tbansal1, 2015/10/12 17:05:18]

No, I do not think I need any of those properties. It seems that
|data_use_aggregator| can also move to IOThread? I just wanted to keep them
together. wdyt?

[tbansal1, 2015/10/12 22:39:14]

Done.

[tbansal1, 2015/10/12 22:39:14]

Done.

     // The "system" NetworkDelegate, used for Profile-agnostic network events.
     scoped_ptr<net::NetworkDelegate> system_network_delegate;
     scoped_ptr<net::HostResolver> host_resolver;
     scoped_ptr<net::CertVerifier> cert_verifier;
     // The ChannelIDService must outlive the HttpTransactionFactory.
     scoped_ptr<net::ChannelIDService> system_channel_id_service;
     // This TransportSecurityState doesn't load or save any state. It's only
     // used to enforce pinning for system requests and will only use built-in
     // pins.
     scoped_ptr<net::TransportSecurityState> transport_security_state;
@@ skipping 372 matching lines @@
   bool is_quic_allowed_by_policy_;
 
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_