Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1393033002: Move super initializers to end of list (Closed)

Created:
5 years, 2 months ago by hausner
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Ivan Posva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move super initializers to end of list Avoid two-phase super constructor call chain in a couple of library constructors. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/11965d24e673c54bedcab7690fee6f4807b98b1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M sdk/lib/convert/json.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 2 months ago (2015-10-07 17:56:42 UTC) #2
rmacnak
lgtm
5 years, 2 months ago (2015-10-07 17:58:07 UTC) #3
hausner
5 years, 2 months ago (2015-10-07 18:05:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11965d24e673c54bedcab7690fee6f4807b98b1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698