Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9209)

Unified Diff: chrome/common/extensions/docs/server2/content_providers_test.py

Issue 139303023: add GCS support to docs server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bumped versions Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/content_providers_test.py
diff --git a/chrome/common/extensions/docs/server2/content_providers_test.py b/chrome/common/extensions/docs/server2/content_providers_test.py
index 7ced6da6885f3a98b3185253348c7c46a59c9c25..e153f8f202feafb49bb806c1ba28a5548ee00d82 100755
--- a/chrome/common/extensions/docs/server2/content_providers_test.py
+++ b/chrome/common/extensions/docs/server2/content_providers_test.py
@@ -12,6 +12,7 @@ from extensions_paths import EXTENSIONS
from object_store_creator import ObjectStoreCreator
from test_file_system import TestFileSystem
from test_util import DisableLogging
+from gcs_file_system_provider import CloudStorageFileSystemProvider
_CONTENT_PROVIDERS = {
@@ -102,10 +103,14 @@ class ContentProvidersTest(unittest.TestCase):
def setUp(self):
test_file_system = TestFileSystem(_FILE_SYSTEM_DATA, relative_to=EXTENSIONS)
self._github_fs_provider = _MockGithubFileSystemProvider(test_file_system)
+ object_store_creator = ObjectStoreCreator.ForTest()
+ # TODO(mangini): create tests for GCS
Jeffrey Yasskin 2014/01/29 01:08:08 I'm nervous about checking things in without tests
Renato Mangini (chromium) 2014/01/31 02:29:04 I agree with you. If you don't mind, I commit myse
Jeffrey Yasskin 2014/02/03 22:12:56 SG
+ self._gcs_fs_provider = CloudStorageFileSystemProvider(object_store_creator)
self._content_providers = ContentProviders(
- CompiledFileSystem.Factory(ObjectStoreCreator.ForTest()),
+ CompiledFileSystem.Factory(object_store_creator),
test_file_system,
- self._github_fs_provider)
+ self._github_fs_provider,
+ self._gcs_fs_provider)
def testSimpleRootPath(self):
provider = self._content_providers.GetByName('apples')

Powered by Google App Engine
This is Rietveld 408576698