| OLD | NEW |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 from branch_utility import BranchUtility | 5 from branch_utility import BranchUtility |
| 6 from compiled_file_system import CompiledFileSystem | 6 from compiled_file_system import CompiledFileSystem |
| 7 from environment import IsDevServer | 7 from environment import IsDevServer |
| 8 from github_file_system_provider import GithubFileSystemProvider | 8 from github_file_system_provider import GithubFileSystemProvider |
| 9 from host_file_system_provider import HostFileSystemProvider | 9 from host_file_system_provider import HostFileSystemProvider |
| 10 from third_party.json_schema_compiler.memoize import memoize | 10 from third_party.json_schema_compiler.memoize import memoize |
| 11 from render_servlet import RenderServlet | 11 from render_servlet import RenderServlet |
| 12 from object_store_creator import ObjectStoreCreator | 12 from object_store_creator import ObjectStoreCreator |
| 13 from server_instance import ServerInstance | 13 from server_instance import ServerInstance |
| 14 from gcs_file_system_provider import CloudStorageFileSystemProvider |
| 14 | 15 |
| 15 class InstanceServletRenderServletDelegate(RenderServlet.Delegate): | 16 class InstanceServletRenderServletDelegate(RenderServlet.Delegate): |
| 16 '''AppEngine instances should never need to call out to SVN. That should only | 17 '''AppEngine instances should never need to call out to SVN. That should only |
| 17 ever be done by the cronjobs, which then write the result into DataStore, | 18 ever be done by the cronjobs, which then write the result into DataStore, |
| 18 which is as far as instances look. To enable this, crons can pass a custom | 19 which is as far as instances look. To enable this, crons can pass a custom |
| 19 (presumably online) ServerInstance into Get(). | 20 (presumably online) ServerInstance into Get(). |
| 20 | 21 |
| 21 Why? SVN is slow and a bit flaky. Cronjobs failing is annoying but temporary. | 22 Why? SVN is slow and a bit flaky. Cronjobs failing is annoying but temporary. |
| 22 Instances failing affects users, and is really bad. | 23 Instances failing affects users, and is really bad. |
| 23 | 24 |
| (...skipping 14 matching lines...) Expand all Loading... |
| 38 # development it's annoying to have to run the cron job, so offline=False. | 39 # development it's annoying to have to run the cron job, so offline=False. |
| 39 host_file_system_provider = self._delegate.CreateHostFileSystemProvider( | 40 host_file_system_provider = self._delegate.CreateHostFileSystemProvider( |
| 40 object_store_creator, | 41 object_store_creator, |
| 41 offline=not IsDevServer()) | 42 offline=not IsDevServer()) |
| 42 github_file_system_provider = self._delegate.CreateGithubFileSystemProvider( | 43 github_file_system_provider = self._delegate.CreateGithubFileSystemProvider( |
| 43 object_store_creator) | 44 object_store_creator) |
| 44 return ServerInstance(object_store_creator, | 45 return ServerInstance(object_store_creator, |
| 45 CompiledFileSystem.Factory(object_store_creator), | 46 CompiledFileSystem.Factory(object_store_creator), |
| 46 branch_utility, | 47 branch_utility, |
| 47 host_file_system_provider, | 48 host_file_system_provider, |
| 48 github_file_system_provider) | 49 github_file_system_provider, |
| 50 CloudStorageFileSystemProvider(object_store_creator)) |
| 49 | 51 |
| 50 class InstanceServlet(object): | 52 class InstanceServlet(object): |
| 51 '''Servlet for running on normal AppEngine instances. | 53 '''Servlet for running on normal AppEngine instances. |
| 52 Create this via GetConstructor() so that cache state can be shared amongst | 54 Create this via GetConstructor() so that cache state can be shared amongst |
| 53 them via the memoizing Delegate. | 55 them via the memoizing Delegate. |
| 54 ''' | 56 ''' |
| 55 class Delegate(object): | 57 class Delegate(object): |
| 56 '''Allow runtime dependencies to be overriden for testing. | 58 '''Allow runtime dependencies to be overriden for testing. |
| 57 ''' | 59 ''' |
| 58 def CreateBranchUtility(self, object_store_creator): | 60 def CreateBranchUtility(self, object_store_creator): |
| 59 return BranchUtility.Create(object_store_creator) | 61 return BranchUtility.Create(object_store_creator) |
| 60 | 62 |
| 61 def CreateHostFileSystemProvider(self, object_store_creator, **optargs): | 63 def CreateHostFileSystemProvider(self, object_store_creator, **optargs): |
| 62 return HostFileSystemProvider(object_store_creator, **optargs) | 64 return HostFileSystemProvider(object_store_creator, **optargs) |
| 63 | 65 |
| 64 def CreateGithubFileSystemProvider(self, object_store_creator): | 66 def CreateGithubFileSystemProvider(self, object_store_creator): |
| 65 return GithubFileSystemProvider(object_store_creator) | 67 return GithubFileSystemProvider(object_store_creator) |
| 66 | 68 |
| 67 @staticmethod | 69 @staticmethod |
| 68 def GetConstructor(delegate_for_test=None): | 70 def GetConstructor(delegate_for_test=None): |
| 69 render_servlet_delegate = InstanceServletRenderServletDelegate( | 71 render_servlet_delegate = InstanceServletRenderServletDelegate( |
| 70 delegate_for_test or InstanceServlet.Delegate()) | 72 delegate_for_test or InstanceServlet.Delegate()) |
| 71 return lambda request: RenderServlet(request, render_servlet_delegate) | 73 return lambda request: RenderServlet(request, render_servlet_delegate) |
| 72 | 74 |
| 73 # NOTE: if this were a real Servlet it would implement a Get() method, but | 75 # NOTE: if this were a real Servlet it would implement a Get() method, but |
| 74 # GetConstructor returns an appropriate lambda function (Request -> Servlet). | 76 # GetConstructor returns an appropriate lambda function (Request -> Servlet). |
| OLD | NEW |