Replace use of base::RandXXX() with rand() to improve runtime of SeekableBufferTest.

media/base/seekable_buffer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <cstdlib>
+
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/rand_util.h"
 #include "base/time/time.h"
 #include "media/base/data_buffer.h"
 #include "media/base/seekable_buffer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 
 class SeekableBufferTest : public testing::Test {
  public:
   SeekableBufferTest() : buffer_(kBufferSize, kBufferSize) {
   }
 
  protected:
   static const int kDataSize = 409600;

[DaleCurtis, 2014/01/17 23:28:21]

Geez are we really allocating 400k of data for this test?

   static const int kBufferSize = 4096;
   static const int kWriteSize = 512;
 
   virtual void SetUp() {
+    // Note: We use srand() and rand() rather than base::RandXXX() to improve
+    // unit test performance.  We don't need good random numbers, just
+    // something that generates "mixed data."
+    const unsigned int kKnownSeed = 0x98765432;
+    srand(kKnownSeed);
+
     // Create random test data samples.
     for (int i = 0; i < kDataSize; i++)
-      data_[i] = static_cast<char>(base::RandInt(0, 255));
+      data_[i] = static_cast<char>(rand());

[DaleCurtis, 2014/01/17 23:28:21]

You might try base::RandBytes()... after this CL that I just wrote haha:
https://codereview.chromium.org/140773006/

   }
 
   int GetRandomInt(int maximum) {
-    return base::RandInt(0, maximum);
+    return rand() % (maximum + 1);
   }
 
   SeekableBuffer buffer_;
   uint8 data_[kDataSize];
   uint8 write_buffer_[kDataSize];
 };
 
 TEST_F(SeekableBufferTest, RandomReadWrite) {
   int write_position = 0;
   int read_position = 0;
@@ skipping 296 matching lines @@
     EXPECT_EQ(tests[i].expected_time, actual) << "With test = { start:"
         << tests[i].first_time_useconds << ", duration:"
         << tests[i].duration_useconds << ", consumed:"
         << tests[i].consume_bytes << " }\n";
 
     buffer_.Clear();
   }
 }
 
 }  // namespace media