Feed the render data to MediaStreamAudioProcessor and used AudioBus in render callback

content/renderer/media/media_stream_audio_processor_unittest.cc

Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index f562055905169867fc91af330194afa3481a1c1f..e37fd68093802b1fd9c1bb948c9fcce93dfa4e88 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -80,10 +80,9 @@ class MediaStreamAudioProcessorTest : public ::testing::Test {
 
       // |audio_processor| does nothing when the audio processing is off in
       // the processor.
-      audio_processor->PushRenderData(
-          data_ptr,
-          params_.sample_rate(), params_.channels(),
-          params_.frames_per_buffer(), base::TimeDelta::FromMilliseconds(10));
+      if (audio_processor->has_audio_processing())

[tommi (sloooow) - chröme, 2014/02/06 16:47:01]

{}

Since you check for has_audio_processing() here, then that means that aec might
*not* be enabled even though other audio processing is performed.
It might also be possible that hw aec is being used so the APM's AEC is actually
disabled.   So, I'm not sure about that DCHECK in the other file.

[no longer working on chromium, 2014/02/06 17:20:14]

The current unittests only contains the test cases where we either turn on all
the components or turn off all the components.

That is why checking has_audio_processing() is sufficient today because we don't
have test cases where AEC is diabled while other components are enabled.

Anyway, it might be better to check if AEC is enabled or not here since it
generates question.

Done with changing it.

[tommi (sloooow) - chröme, 2014/02/06 17:58:44]

thanks

+        audio_processor->OnPlayoutData(data_bus.get(), params_.sample_rate(),
+                                       10);
 
       int16* output = NULL;
       int new_volume = 0;
@@ -145,7 +144,7 @@ TEST_F(MediaStreamAudioProcessorTest, WithoutAudioProcessing) {
   // Setup the audio processor without enabling the flag.
   blink::WebMediaConstraints constraints;
   scoped_refptr<MediaStreamAudioProcessor> audio_processor(
-      new MediaStreamAudioProcessor(params_, constraints, 0));
+      new MediaStreamAudioProcessor(params_, constraints, 0, NULL));
   EXPECT_FALSE(audio_processor->has_audio_processing());
 
   ProcessDataAndVerifyFormat(audio_processor,
@@ -160,7 +159,7 @@ TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
       switches::kEnableAudioTrackProcessing);
   blink::WebMediaConstraints constraints;
   scoped_refptr<MediaStreamAudioProcessor> audio_processor(
-      new MediaStreamAudioProcessor(params_, constraints, 0));
+      new MediaStreamAudioProcessor(params_, constraints, 0, NULL));
   EXPECT_TRUE(audio_processor->has_audio_processing());
   VerifyDefaultComponents(audio_processor);