content/renderer/media/webrtc_audio_capturer.h - Issue 139303016: Feed the render data to MediaStreamAudioProcessor and used AudioBus in render callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.h

Issue 139303016: Feed the render data to MediaStreamAudioProcessor and used AudioBus in render callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed Per's comments. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_processor_unittest.cc ('K') | « content/renderer/media/media_stream_audio_processor_unittest.cc ('k') | content/renderer/media/webrtc_audio_capturer.cc » ('j') | content/renderer/media/webrtc_audio_device_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer.h

diff --git a/content/renderer/media/webrtc_audio_capturer.h b/content/renderer/media/webrtc_audio_capturer.h

index 986016d38711df24e72b4cfdc5cb31797637b5de..7f198eab1f540caf38f80a4c34dd7457cbdec41e 100644

--- a/content/renderer/media/webrtc_audio_capturer.h

+++ b/content/renderer/media/webrtc_audio_capturer.h

@@ -82,7 +82,6 @@ class CONTENT_EXPORT WebRtcAudioCapturer

int Volume() const;

int MaxVolume() const;

// Audio parameters utilized by the source of the audio capturer.

// TODO(phoglund): Think over the implications of this accessor and if we can

// remove it.

@@ -109,14 +108,6 @@ class CONTENT_EXPORT WebRtcAudioCapturer

void GetAudioProcessingParams(base::TimeDelta* delay, int* volume,

bool* key_pressed);

- // Called by the WebRtcAudioDeviceImpl to push the render audio to

- // audio processor for echo cancellation analysis.

- void FeedRenderDataToAudioProcessor(const int16* render_audio,

- int sample_rate,

- int number_of_channels,

- int number_of_frames,

- base::TimeDelta render_delay);

// Use by the unittests to inject their own source to the capturer.

void SetCapturerSourceForTesting(

const scoped_refptr<media::AudioCapturerSource>& source,