Feed the render data to MediaStreamAudioProcessor and used AudioBus in render callback

content/renderer/media/media_stream_audio_processor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/time/time.h"
@@ skipping 62 matching lines @@
     ReadDataFromSpeechFile(capture_data.get(), length);
     const int16* data_ptr = reinterpret_cast<const int16*>(capture_data.get());
     scoped_ptr<media::AudioBus> data_bus = media::AudioBus::Create(
         params_.channels(), params_.frames_per_buffer());
     for (int i = 0; i < kNumberOfPacketsForTest; ++i) {
       data_bus->FromInterleaved(data_ptr, data_bus->frames(), 2);
       audio_processor->PushCaptureData(data_bus.get());
 
       // |audio_processor| does nothing when the audio processing is off in
       // the processor.
-      audio_processor->PushRenderData(
-          data_ptr,
-          params_.sample_rate(), params_.channels(),
-          params_.frames_per_buffer(), base::TimeDelta::FromMilliseconds(10));
+      if (audio_processor->has_audio_processing()) {
+        static_cast<WebRtcAudioRendererSource*>(audio_processor)->RenderData(

[miu, 2014/01/24 22:27:19]

This threw me off a bit.  I see that you're trying to call a private method of
MediaStreamAudioProcessor here.  I'll leave it up to you, but IMHO it's more
readable to make MediaStreamAudioProcessorTest a friend class of
MediaStreamAudioProcessor, which would allow you to invoke RenderData() without
the static_cast<> here.

[no longer working on chromium, 2014/01/27 17:09:33]

Actually MediaStreamAudioProcessorTest had been made a friend class of
MediaStreamAudioProcessor in my another CL. So I removed the static_cast after
rebasing.

+            data_bus.get(), params_.sample_rate(), 10);
+      }
 
       int16* output = NULL;
       while(audio_processor->ProcessAndConsumeData(
           base::TimeDelta::FromMilliseconds(10), 255, false, &output)) {
         EXPECT_TRUE(output != NULL);
         EXPECT_EQ(audio_processor->OutputFormat().sample_rate(),
                   expected_output_sample_rate);
         EXPECT_EQ(audio_processor->OutputFormat().channels(),
                   expected_output_channels);
         EXPECT_EQ(audio_processor->OutputFormat().frames_per_buffer(),
                   expected_output_buffer_size);
       }
 
       data_ptr += params_.frames_per_buffer() * params_.channels();
     }
   }
 
   media::AudioParameters params_;
 };
 
 TEST_F(MediaStreamAudioProcessorTest, WithoutAudioProcessing) {
   // Setup the audio processor without enabling the flag.
   blink::WebMediaConstraints constraints;
   scoped_refptr<MediaStreamAudioProcessor> audio_processor(
-      new MediaStreamAudioProcessor(params_, constraints, 0));
+      new MediaStreamAudioProcessor(params_, constraints, 0, NULL));
   EXPECT_FALSE(audio_processor->has_audio_processing());
 
   ProcessDataAndVerifyFormat(audio_processor,
                              params_.sample_rate(),
                              params_.channels(),
                              params_.sample_rate() / 100);
 }
 
 TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
   // Setup the audio processor with enabling the flag.
   CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kEnableAudioTrackProcessing);
   blink::WebMediaConstraints constraints;
   scoped_refptr<MediaStreamAudioProcessor> audio_processor(
-      new MediaStreamAudioProcessor(params_, constraints, 0));
+      new MediaStreamAudioProcessor(params_, constraints, 0, NULL));
   EXPECT_TRUE(audio_processor->has_audio_processing());
 
   ProcessDataAndVerifyFormat(audio_processor,
                              kAudioProcessingSampleRate,
                              kAudioProcessingNumberOfChannel,
                              kAudioProcessingSampleRate / 100);
 }
 
 }  // namespace content