Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 139303014: Revert 245433 "Linux Aura: Added --use-system-title-bar flag." (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245433 "Linux Aura: Added --use-system-title-bar flag." DesktopScreenX11Test.GetWindowAtScreenPoint in views_unittests is faling on "Linux Aura Tests" after this change. http://build.chromium.org/p/chromium.linux/builders/Linux%20Aura%20Tests/builds/701 > Linux Aura: Added --use-system-title-bar flag. > > This flag makes browser windows use the system window dressing and title > bar, instead of the custom frame. This is a Linux Aura equivalent of the > "Use System Title Bar and Border" preference in Linux GTK. (Eventually, > this part will be controlled by the same preference, rather than this > flag.) > > With this flag, browser windows use the native system window decoration, > with our custom close/minimize/maximize buttons removed, and the tab > strip being condensed vertically with square corners (like the maximized > tab strip). Popup browser windows (including V1 apps and the Developer > Tools window) drop the blue custom frame altogether in favour of the > native frame. > > BUG=317859 > TEST=With --use-system-title-bar, open a browser window. Both maximized > and restored windows should have a system native title bar, and the tab > strip should be compacted into a single row (as when maximized). > TEST=With --use-system-title-bar, open a hosted app window. It should > have a system native title bar, with no second blue title bar. > > Review URL: https://codereview.chromium.org/111723012 TBR=mgiuca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -113 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/about_flags.cc View 1 chunk +1 line, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/native_app_window_views.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 7 chunks +4 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 14 chunks +22 lines, -37 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/ui/views/widget/widget.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/ui/views/window/dialog_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
6 years, 11 months ago (2014-01-17 09:57:48 UTC) #1
hashimoto
Committed patchset #1 manually as r245470 (tree was closed).
6 years, 11 months ago (2014-01-17 09:58:09 UTC) #2
Matt Giuca
6 years, 11 months ago (2014-01-20 02:43:31 UTC) #3
Message was sent while issue was closed.
Thanks for dealing with this, Ryo.

It was a legitimate failure, but for some reason the trybots didn't run this
test. :(

Powered by Google App Engine
This is Rietveld 408576698