tools/lexer_generator/dfa.py - Issue 139303008: Experimental parser: fix an assert to be more meaningful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lexer_generator/dfa.py

Issue 139303008: Experimental parser: fix an assert to be more meaningful. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/lexer_generator/dfa.py

diff --git a/tools/lexer_generator/dfa.py b/tools/lexer_generator/dfa.py

index f135b8e1e9d133298be386664c186365bb89a585..a8f29cdbd6a2389fe79e49e68dadd8330beae9b0 100644

--- a/tools/lexer_generator/dfa.py

+++ b/tools/lexer_generator/dfa.py

@@ -189,7 +189,9 @@ class DfaMinimizer:

all_keys.append(state.key_iter())

if action:

if state not in terminal_set:

- assert action.entry_action()

+ # Match actions are valid only if we have matched the whole token, not

+ # just some sub-part of it.

+ assert not action.match_action()

key = ("nonterminal action", action)

else:

key = ("terminal action", action)

« no previous file with comments | « no previous file | no next file » | no next file with comments »