Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: test/cctest/test-atomicops.cc

Issue 1393023003: Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: avoid gcc 4.8 arm compiler bug on release and debug by moving checks to the bottom Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-assembler-arm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-atomicops.cc
diff --git a/test/cctest/test-atomicops.cc b/test/cctest/test-atomicops.cc
index 8b47208ba0adfc2d20bda437e187bf7115613b66..4a59ba68e364cd8d14d097ff2ec904dd46dc77f5 100644
--- a/test/cctest/test-atomicops.cc
+++ b/test/cctest/test-atomicops.cc
@@ -157,21 +157,11 @@ static void TestAtomicExchange() {
template <class AtomicType>
static void TestAtomicIncrementBounds() {
- // Test at rollover boundary between int_max and int_min.
- AtomicType test_val =
- static_cast<AtomicType>(1) << (NUM_BITS(AtomicType) - 1);
- AtomicType value = -1 ^ test_val;
- AtomicType new_value = NoBarrier_AtomicIncrement(&value, 1);
- CHECK_EQU(test_val, value);
- CHECK_EQU(value, new_value);
-
- NoBarrier_AtomicIncrement(&value, -1);
- CHECK_EQU(-1 ^ test_val, value);
-
// Test at 32-bit boundary for 64-bit atomic type.
- test_val = static_cast<AtomicType>(1) << (NUM_BITS(AtomicType) / 2);
- value = test_val - 1;
- new_value = NoBarrier_AtomicIncrement(&value, 1);
+ AtomicType test_val = static_cast<AtomicType>(1)
+ << (NUM_BITS(AtomicType) / 2);
+ AtomicType value = test_val - 1;
+ AtomicType new_value = NoBarrier_AtomicIncrement(&value, 1);
CHECK_EQU(test_val, value);
CHECK_EQU(value, new_value);
« no previous file with comments | « test/cctest/test-assembler-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698