Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 1393023002: Move CT pages / page sets / benchmarks into Telemetry repo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/repaint.py ('k') | tools/perf/ct_benchmarks_util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/skpicture_printer.py
diff --git a/tools/perf/benchmarks/skpicture_printer.py b/tools/perf/benchmarks/skpicture_printer.py
index 0247320f3135fc28a4620b21e1e8fcdacbb0f5a3..3ba8834b89f89441aea0718374dd2501e18e14c0 100644
--- a/tools/perf/benchmarks/skpicture_printer.py
+++ b/tools/perf/benchmarks/skpicture_printer.py
@@ -4,6 +4,8 @@
from core import perf_benchmark
+import ct_benchmarks_util
+import page_sets
from telemetry import benchmark
from telemetry.core import discover
from telemetry import story
@@ -48,3 +50,32 @@ class SkpicturePrinter(perf_benchmark.PerfBenchmark):
story_set_class = _MatchPageSetName(options.page_set_name,
options.page_set_base_dir)
return story_set_class()
+
+
+# Disabled because we do not plan on running CT benchmarks on the perf
+# waterfall any time soon.
+@benchmark.Disabled
+class SkpicturePrinterCT(perf_benchmark.PerfBenchmark):
+ """Captures SKPs for Cluster Telemetry."""
+
+ @classmethod
+ def Name(cls):
+ return 'skpicture_printer_ct'
+
+ @classmethod
+ def AddBenchmarkCommandLineArgs(cls, parser):
+ ct_benchmarks_util.AddBenchmarkCommandLineArgs(parser)
+ parser.add_option('-s', '--skp-outdir',
+ default=None,
+ help='Output directory for the SKP files')
+
+ @classmethod
+ def ProcessCommandLineArgs(cls, parser, args):
+ ct_benchmarks_util.ValidateCommandLineArgs(parser, args)
+
+ def CreatePageTest(self, options):
+ return skpicture_printer.SkpicturePrinter(options.skp_outdir)
+
+ def CreateStorySet(self, options):
+ return page_sets.CTPageSet(
+ options.urls_list, options.user_agent, options.archive_data_file)
« no previous file with comments | « tools/perf/benchmarks/repaint.py ('k') | tools/perf/ct_benchmarks_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698