Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: ash/frame/default_header_painter.cc

Issue 1393013007: Add a Canvas::SaveAndUnscale() method for pixel-accurate drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | ui/gfx/canvas.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/frame/default_header_painter.cc
diff --git a/ash/frame/default_header_painter.cc b/ash/frame/default_header_painter.cc
index a80a3c6bc0ced68a0adaa13104d5ca2c4a571fbf..ab9dd1806f17940a428f9d920d350e5048d10085 100644
--- a/ash/frame/default_header_painter.cc
+++ b/ash/frame/default_header_painter.cc
@@ -262,18 +262,13 @@ void DefaultHeaderPainter::PaintTitleBar(gfx::Canvas* canvas) {
}
void DefaultHeaderPainter::PaintHeaderContentSeparator(gfx::Canvas* canvas) {
- SkColor color = (mode_ == MODE_ACTIVE) ?
- kHeaderContentSeparatorColor :
- kHeaderContentSeparatorInactiveColor;
-
+ const float scale = canvas->SaveAndUnscale();
+ gfx::RectF rect(0, painted_height_ * scale - 1, view_->width() * scale, 1);
SkPaint paint;
- paint.setColor(color);
- // Draw the line as 1px thick regardless of scale factor.
- paint.setStrokeWidth(0);
-
- float thickness = 1 / canvas->image_scale();
- SkScalar y = SkIntToScalar(painted_height_) - SkFloatToScalar(thickness);
- canvas->sk_canvas()->drawLine(0, y, SkIntToScalar(view_->width()), y, paint);
+ paint.setColor((mode_ == MODE_ACTIVE) ?
+ kHeaderContentSeparatorColor : kHeaderContentSeparatorInactiveColor);
+ canvas->sk_canvas()->drawRect(gfx::RectFToSkRect(rect), paint);
+ canvas->Restore();
}
void DefaultHeaderPainter::LayoutLeftHeaderView() {
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | ui/gfx/canvas.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698