Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: runtime/vm/thread.h

Issue 1393013005: Fix GC problem with vm_handles in thread (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.h
diff --git a/runtime/vm/thread.h b/runtime/vm/thread.h
index 93d7e0e17a8688f530df90beb07da0826b0e8eef..4b9b9c9c6ba36d48000881410b6b9c330c8835f3 100644
--- a/runtime/vm/thread.h
+++ b/runtime/vm/thread.h
@@ -348,15 +348,17 @@ LEAF_RUNTIME_ENTRY_LIST(DEFINE_OFFSET_METHOD)
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_SCOPE_ACCESSORS)
#undef REUSABLE_HANDLE_SCOPE_ACCESSORS
-bool IsAnyReusableHandleScopeActive() const {
+ bool IsAnyReusableHandleScopeActive() const {
#define IS_REUSABLE_HANDLE_SCOPE_ACTIVE(object) \
- if (reusable_##object##_handle_scope_active_) return true;
- REUSABLE_HANDLE_LIST(IS_REUSABLE_HANDLE_SCOPE_ACTIVE)
- return false;
+ if (reusable_##object##_handle_scope_active_) return true;
+ REUSABLE_HANDLE_LIST(IS_REUSABLE_HANDLE_SCOPE_ACTIVE)
+ return false;
#undef IS_REUSABLE_HANDLE_SCOPE_ACTIVE
-}
+ }
#endif // defined(DEBUG)
+ void ClearReusableHandles();
+
#define REUSABLE_HANDLE(object) \
object& object##Handle() const { \
return *object##_handle_; \
« no previous file with comments | « no previous file | runtime/vm/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698