Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1392973005: Get rid of CookieMonster::Delegate typedef. (Closed)

Created:
5 years, 2 months ago by davidben
Modified:
5 years, 2 months ago
Reviewers:
Devlin, mmenke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of CookieMonster::Delegate typedef. Almost everything's switched to the new one by now. Finish the job. BUG=none Committed: https://crrev.com/2a03078ea69b3ee89cc51c6cab1efd0b0ed16b66 Cr-Commit-Position: refs/heads/master@{#353586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_cookie_monster_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_cookie_monster_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_cookie_notification_details.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
davidben
5 years, 2 months ago (2015-10-09 21:57:10 UTC) #2
mmenke
LGTM...Kinda weird rename - normally this sort of thing is accompanied by moving the delegate ...
5 years, 2 months ago (2015-10-09 22:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392973005/1
5 years, 2 months ago (2015-10-10 19:13:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/108419)
5 years, 2 months ago (2015-10-10 19:20:25 UTC) #7
davidben
+rdevlin.cronin for chrome/browser/extensions/. (Completely mechanical change.)
5 years, 2 months ago (2015-10-12 17:10:04 UTC) #9
Devlin
lgtm
5 years, 2 months ago (2015-10-12 18:47:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392973005/1
5 years, 2 months ago (2015-10-12 18:50:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 20:22:49 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:23:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a03078ea69b3ee89cc51c6cab1efd0b0ed16b66
Cr-Commit-Position: refs/heads/master@{#353586}

Powered by Google App Engine
This is Rietveld 408576698