Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1392943003: net: Move dns_reloader.* into dns directory. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Move dns_reloader.* into dns directory. It is DNS specific so it makes more sense to have it in net/dns rather than in the generic net/base directory. BUG=None R=mmenke@chromium.org Committed: https://crrev.com/47598f041e65b345ed00b62ba6fd9d0c69219bd3 Cr-Commit-Position: refs/heads/master@{#352967}

Patch Set 1 #

Patch Set 2 : sort better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -156 lines) Patch
D net/base/dns_reloader.h View 1 chunk +0 lines, -23 lines 0 comments Download
D net/base/dns_reloader.cc View 1 chunk +0 lines, -125 lines 0 comments Download
A + net/dns/dns_reloader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/dns/dns_reloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/dns/host_resolver_proc.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 2 months ago (2015-10-07 17:18:24 UTC) #1
mmenke
Thanks for doing this! LGTM
5 years, 2 months ago (2015-10-07 17:21:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392943003/20001
5 years, 2 months ago (2015-10-07 23:00:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 23:08:47 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 23:09:23 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47598f041e65b345ed00b62ba6fd9d0c69219bd3
Cr-Commit-Position: refs/heads/master@{#352967}

Powered by Google App Engine
This is Rietveld 408576698