Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's.

Trying this patch again. From what we can tell it was a glitch in the MAC WebKit builder since it seemed to recover before the change was reverted.

Create our own blink_heap run_all_tests target to avoid piggy-backing on wtf's.

We used to use wtf's run_all_tests target to run out blink heap unittests. That causes a problem when we want to initialize our heap since we cannot call Heap::init/shutdown from wtf's RunAllTests since it cannot/should not depend on blink heap.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165205

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165217

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165305

[Mads Ager (chromium), 2014-01-15 09:44:48]

lgtm

[commit-bot: I haz the power, 2014-01-15 09:49:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/1

[haraken, 2014-01-15 10:42:02]

LGTM

[commit-bot: I haz the power, 2014-01-15 16:51:35]

Retried try job too often on mac_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2014-01-16 08:34:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/1

[commit-bot: I haz the power, 2014-01-16 08:51:08]

Change committed as 165205

[wibling-chromium, 2014-01-16 09:14:39]

A revert of this CL has been created in
https://codereview.chromium.org/135853018/ by wibling@chromium.org.

The reason for reverting is: Failing blink_heap_unittests on MAC. .

[commit-bot: I haz the power, 2014-01-16 10:09:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/250001

[commit-bot: I haz the power, 2014-01-16 10:52:36]

Retried try job too often on linux_blink for step(s) wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-16 11:39:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/250001

[commit-bot: I haz the power, 2014-01-16 12:13:06]

Retried try job too often on linux_blink for step(s) wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-16 12:27:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/250001

[commit-bot: I haz the power, 2014-01-16 12:58:26]

Change committed as 165217

[wibling-chromium, 2014-01-16 13:41:30]

A revert of this CL has been created in
https://codereview.chromium.org/139623003/ by wibling@chromium.org.

The reason for reverting is: This change triggered an issue with out assembly
code. Reverting until fixed..

[commit-bot: I haz the power, 2014-01-17 10:47:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/139293003/360002

[commit-bot: I haz the power, 2014-01-17 11:54:47]

Change committed as 165305

[tfarina, 2014-02-08 04:47:47]

If we don't have a good reason, I'm proposing merging blink_heap_run_all_tests
into blink_heap_unittests.

Thanks!

https://codereview.chromium.org/139293003/diff/360002/Source/heap/blink_heap_...
File Source/heap/blink_heap_tests.gyp (right):

https://codereview.chromium.org/139293003/diff/360002/Source/heap/blink_heap_...
Source/heap/blink_heap_tests.gyp:59: 'target_name': 'blink_heap_run_all_tests',
you certainly do not need this to be a separate target. blink_heap_unittests is
executable, so RunAllTests.cpp can be part of it.

Do you have a strong reason to keep this separate? If yes, I'm curious to know
which is.

[Mads Ager (chromium), 2014-02-17 09:12:36]

On 2014/02/08 04:47:47, tfarina wrote:
> If we don't have a good reason, I'm proposing merging blink_heap_run_all_tests
> into blink_heap_unittests.
> 
> Thanks!
> 
>
https://codereview.chromium.org/139293003/diff/360002/Source/heap/blink_heap_...
> File Source/heap/blink_heap_tests.gyp (right):
> 
>
https://codereview.chromium.org/139293003/diff/360002/Source/heap/blink_heap_...
> Source/heap/blink_heap_tests.gyp:59: 'target_name':
'blink_heap_run_all_tests',
> you certainly do not need this to be a separate target. blink_heap_unittests
is
> executable, so RunAllTests.cpp can be part of it.
> 
> Do you have a strong reason to keep this separate? If yes, I'm curious to know
> which is.

I doesn't really matter. This was following what was done for the wtf test
targets where the run all tests part can be reused for multiple test targets. If
you have a strong preference for moving that file into the blink_heap_tests
target we can just do that.