Issue 139293002: Log a warning when the initial blocking policy fetch times out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139293002: Log a warning when the initial blocking policy fetch times out. (Closed)

Created:
6 years, 11 months ago by Joao da Silva

Modified:
6 years, 11 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Log a warning when the initial blocking policy fetch times out. This will help diagnosing bugs caused by the timeout. This change also changes the UMA sampling of the times involved in the fetching process, since UMA_HISTOGRAM_TIMES is clamped to a maximum sample of 10 seconds. BUG=334107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245092

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -10 lines)			Patch
	M	chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc	View		6 chunks	+21 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Hi Mattias, please have a look. The timeout isn't increased in this CL because current ...

6 years, 11 months ago (2014-01-15 09:20:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/139293002/1

6 years, 11 months ago (2014-01-15 13:02:15 UTC) #3

Message was sent while issue was closed.

Change committed as 245092

Expand Messages | Collapse Messages