Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1392913003: Add warning icon to media throttle info bar to make it consistent with others (Closed)

Created:
5 years, 2 months ago by qinmin
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add warning icon to media throttle info bar to make it consistent with others As suggested in the crbug. BUG=532745 Committed: https://crrev.com/bd8f5de058d1d59c780df4663fd86a9b7ab3ab00 Cr-Commit-Position: refs/heads/master@{#353179}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/android/media/media_throttle_infobar_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/media/media_throttle_infobar_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
qinmin
PTAL
5 years, 2 months ago (2015-10-07 22:53:37 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 2 months ago (2015-10-08 20:38:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392913003/1
5 years, 2 months ago (2015-10-08 21:13:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/131199)
5 years, 2 months ago (2015-10-08 21:56:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392913003/20001
5 years, 2 months ago (2015-10-08 23:52:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 00:14:17 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 00:15:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd8f5de058d1d59c780df4663fd86a9b7ab3ab00
Cr-Commit-Position: refs/heads/master@{#353179}

Powered by Google App Engine
This is Rietveld 408576698