[Interpreter] Adds shift operators to interpreter

test/cctest/interpreter/test-interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/execution.h"
 #include "src/handles.h"
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 334 matching lines @@
 
     InterpreterTester tester(handles.main_isolate(), bytecode_array);
     auto callable = tester.GetCallable<>();
     Handle<Object> return_val = callable().ToHandleChecked();
     CHECK(return_val.is_identical_to(true_value));
   }
 }
 
 
 static const Token::Value kArithmeticOperators[] = {
-    Token::Value::ADD, Token::Value::SUB, Token::Value::MUL, Token::Value::DIV,
-    Token::Value::MOD};
+    Token::Value::SHL, Token::Value::SAR, Token::Value::SHR, Token::Value::ADD,
+    Token::Value::SUB, Token::Value::MUL, Token::Value::DIV, Token::Value::MOD};
 
 
 static double BinaryOpC(Token::Value op, double lhs, double rhs) {
   switch (op) {
     case Token::Value::ADD:
       return lhs + rhs;
     case Token::Value::SUB:
       return lhs - rhs;
     case Token::Value::MUL:
       return lhs * rhs;
     case Token::Value::DIV:
       return lhs / rhs;
     case Token::Value::MOD:
       return std::fmod(lhs, rhs);
+    case Token::Value::SHL: {
+      int32_t val = v8::internal::DoubleToInt32(lhs);
+      uint32_t count = v8::internal::DoubleToUint32(rhs) & 0x1F;
+      return val << count;
+    }
+    case Token::Value::SAR: {
+      int32_t val = v8::internal::DoubleToInt32(lhs);
+      uint32_t count = v8::internal::DoubleToUint32(rhs) & 0x1F;
+      return val >> count;
+    }
+    case Token::Value::SHR: {
+      uint32_t val = v8::internal::DoubleToUint32(lhs);
+      uint32_t count = v8::internal::DoubleToUint32(rhs) & 0x1F;
+      return val >> count;

[oth, 2015/10/07 13:53:17]

Can we have a separate test for the shift operators?

The inputs in BinaryOpsSmi don't test the edge cases for shifts. (Shift 0, 31,
32, >32).

[mythria, 2015/10/08 14:33:44]

Done.

+    }
     default:
       UNREACHABLE();
       return std::numeric_limits<double>::min();
   }
 }
 
 
 TEST(InterpreterBinaryOpsSmi) {
   int lhs_inputs[] = {3266, 1024, 0, -17, -18000};
   int rhs_inputs[] = {3266, 5, 4, 3, 2, 1, -1, -2};
@@ skipping 1083 matching lines @@
       .CallRuntime(Runtime::kAdd, Register(0), 2)
       .Return();
   Handle<BytecodeArray> bytecode_array = builder.ToBytecodeArray();
 
   InterpreterTester tester(handles.main_isolate(), bytecode_array);
   auto callable = tester.GetCallable<>();
 
   Handle<Object> return_val = callable().ToHandleChecked();
   CHECK_EQ(Smi::cast(*return_val), Smi::FromInt(55));
 }