Issue 13929020: Artifically delay the load finished signal until after dom content loaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13929020: Artifically delay the load finished signal until after dom content loaded (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 8 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Artifically delay the load finished signal until after dom content loaded The webNavigation API defines that the signals always arrive in that order. However, the frame loader can finish loading the document before the parser actually finished parsing. To work around this, we delay the finished load signal until after parsing has finished. BUG=230767 TEST=WebNavigationApiTest.SrcDoc doesn't fail flakily Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194539

Patch Set 1 #

Patch Set 2 : updates #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/frame_navigation_state.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

7 years, 8 months ago (2013-04-17 06:10:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r194539 (presubmit successful).

Expand Messages | Collapse Messages