Issue 13929019: Delete gm after use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13929019: Delete gm after use. (Closed)

Created:
7 years, 8 months ago by scroggo

Modified:
7 years, 8 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Delete gm after use. Fixes a memory leak when using the --modulo flag. Instead of deleting manually in each case we are done with it (which led to missing one case), use an SkAutoTDelete. Committed: https://code.google.com/p/skia/source/detail?r=8707

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	gm/gmmain.cpp	View		3 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 8 months ago (2013-04-16 19:11:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8707 (presubmit successful).

Expand Messages | Collapse Messages