In precompilation, finalize all classes eagerly. Use the stable class hierarchy for doing CHA based…

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 2755 matching lines @@
   return raw_ptr()->invocation_dispatcher_cache_;
 }
 
 
 void Class::set_invocation_dispatcher_cache(const Array& cache) const {
   StorePointer(&raw_ptr()->invocation_dispatcher_cache_, cache.raw());
 }
 
 
 void Class::Finalize() const {
+  ASSERT(IsSignatureClass() || !Isolate::Current()->all_classes_finalized());

[rmacnak, 2015/10/14 16:38:48]

Add note that signature classes may be added after we've finalized all the
regular classes when we encounter local functions.

[srdjan, 2015/10/14 16:51:58]

Done.

   ASSERT(!is_finalized());
   // Prefinalized classes have a VM internal representation and no Dart fields.
   // Their instance size  is precomputed and field offsets are known.
   if (!is_prefinalized()) {
     // Compute offsets of instance fields and instance size.
     CalculateFieldOffsets();
   }
   set_is_finalized();
 }
 
@@ skipping 244 matching lines @@
                            const Array& param_values) const {
   const Function& eval_func =
       Function::Handle(EvaluateHelper(*this, expr, param_names, true));
   const Object& result =
       Object::Handle(DartEntry::InvokeFunction(eval_func, param_values));
   return result.raw();
 }
 
 
 // Ensure that top level parsing of the class has been done.
-// TODO(24109): Migrate interface to Thread*.
 RawError* Class::EnsureIsFinalized(Thread* thread) const {
   // Finalized classes have already been parsed.
   if (is_finalized()) {
     return Error::null();
   }
   ASSERT(thread != NULL);
   const Error& error = Error::Handle(
       thread->zone(), Compiler::CompileClass(*this));
   if (!error.IsNull()) {
     ASSERT(thread == Thread::Current());
@@ skipping 18514 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart