Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1392893003: In precompilation, finalize all classes eagerly. Use the stable class hierarchy for doing CHA based… (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In precompilation, finalize all classes eagerly. Use the stable class hierarchy for doing CHA based optimizations: inline implicit setters and getters. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ecd7457bb3cf26f13893a8ebf5bc2e5cf1fba005

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comment; cleanup. #

Patch Set 3 : Allow WeakProperty in snapshot #

Patch Set 4 : Remove dead code #

Patch Set 5 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -17 lines) Patch
M runtime/vm/flow_graph_optimizer.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 6 chunks +31 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/precompiler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 4 3 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 2 months ago (2015-10-13 23:27:19 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1392893003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1392893003/diff/1/runtime/vm/object.cc#newcode2776 runtime/vm/object.cc:2776: ASSERT(IsSignatureClass() || !Isolate::Current()->all_classes_finalized()); Add note that signature classes ...
5 years, 2 months ago (2015-10-14 16:38:48 UTC) #3
srdjan
https://codereview.chromium.org/1392893003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1392893003/diff/1/runtime/vm/object.cc#newcode2776 runtime/vm/object.cc:2776: ASSERT(IsSignatureClass() || !Isolate::Current()->all_classes_finalized()); On 2015/10/14 16:38:48, rmacnak wrote: > ...
5 years, 2 months ago (2015-10-14 16:51:58 UTC) #4
srdjan
5 years, 2 months ago (2015-10-14 20:18:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
ecd7457bb3cf26f13893a8ebf5bc2e5cf1fba005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698