third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h - Issue 1392863002: Fix HTMLToken::Attribute::value handling in AtomicHTMLToken

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

Issue 1392863002: Fix HTMLToken::Attribute::value handling in AtomicHTMLToken (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style fix. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

diff --git a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

index a79339b95dcf6c2eb30ee86ffdd68d8c061ce214..5b7b904db79e04b443e133173b5f949fecc2bbfa 100644

--- a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

+++ b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

@@ -36,7 +36,7 @@

namespace blink {

-class AtomicHTMLToken {

+class CORE_EXPORT AtomicHTMLToken {

STACK_ALLOCATED();

WTF_MAKE_NONCOPYABLE(AtomicHTMLToken);

public:

@@ -240,7 +240,7 @@ inline void AtomicHTMLToken::initializeAttributes(const HTMLToken::AttributeList

ASSERT(attribute.valueRange.start);

ASSERT(attribute.valueRange.end);

- AtomicString value(attribute.value);

+ AtomicString value(StringImpl::create8BitIfPossible(attribute.value));

const QualifiedName& name = nameForAttribute(attribute);

// FIXME: This is N^2 for the number of attributes.

if (!findAttributeInVector(m_attributes, name))

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.cpp » ('j') | no next file with comments »