Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1392853009: Reland "Add bailout for large objects when allocating arrays in optimized code." (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Add bailout for large objects when allocating arrays in optimized code." This reverts commit dc0adc566809ca0bd3074bceecd34e36cf62cdf0. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5a3929ea4f2be0d3dfc2d24d1179f31cf0228883 Cr-Commit-Position: refs/heads/master@{#31284}

Patch Set 1 #

Patch Set 2 : Skip test where bounds check interferes with forced deopts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Lippautz
5 years, 2 months ago (2015-10-15 09:48:43 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-15 09:49:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392853009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392853009/20001
5 years, 2 months ago (2015-10-15 09:50:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392853009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392853009/20001
5 years, 2 months ago (2015-10-15 09:54:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 09:54:42 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 09:54:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a3929ea4f2be0d3dfc2d24d1179f31cf0228883
Cr-Commit-Position: refs/heads/master@{#31284}

Powered by Google App Engine
This is Rietveld 408576698