Issue 1392833006: Revert of small tidy of benchmarkstream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1392833006: Revert of small tidy of benchmarkstream (Closed)

Created:
5 years, 2 months ago by joshualitt

Modified:
5 years, 2 months ago

Reviewers:
robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@vb4b

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of small tidy of benchmarkstream (patchset #2 id:20001 of https://codereview.chromium.org/1395703002/ ) Reason for revert: Breaks visualbench Original issue's description: > small tidy of benchmarkstream > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/691b6af907e55250a29a7a2a346b63c2026011c3 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a3b8c67ea6e542aecf40d46ce9be45d50ef89660

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -40 lines)			Patch
M	tools/VisualBench/TimingStateMachine.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/VisualBench/TimingStateMachine.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/VisualBench/VisualBenchmarkStream.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tools/VisualBench/VisualBenchmarkStream.cpp	View	2 chunks	+13 lines, -17 lines	0 comments	Download
M	tools/VisualBench/VisualStreamTimingModule.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/VisualBench/VisualStreamTimingModule.cpp	View	1 chunk	+27 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392833006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392833006/1

5 years, 2 months ago (2015-10-14 21:44:59 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-14 21:45:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a3b8c67ea6e542aecf40d46ce9be45d50ef89660

Expand Messages | Collapse Messages