Alternate version of SkLocalMatrixImageFilter using an input.

Implement SkLocalMatrixImageFilter.

At draw time, this filter simply concatenates the given matrix to the 
CTM, and recurses on its input. The matrix is thus applied to any 
upstream filter parameters and crop rects.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/20311d4843f25e6a3d9416456b18780ad5d9c1fa

[reed1, 2015-10-13 18:57:16]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-10-13 18:57:16]

cool -- I was starting to write a GM to exercise the LMIF. I will, and then we
can paste it into this alt. CL as well to compare.

[reed1, 2015-10-13 19:31:47]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2015-10-13 19:31:48]

I've uploaded a GM to exercise this here
https://codereview.chromium.org/1388823002

If you can add that to your CL, LGTM (assuming we remove the hacks in
SkCanvas.cpp and un-comment the identity check in the factory).

[reed1, 2015-10-13 19:32:49]

BTW -- (perhaps later) I bet we could query the base filter to see if it is
affected by a given local-matrix. If it is not, we could more aggressively use
the SkRef(this) case in the factory. (e.g. many filters seem unaffected by
translate in the matrix).

[robertphillips, 2015-10-13 19:42:39]

Can we add Mike's GM to this CL ?

https://codereview.chromium.org/1392833005/diff/40001/gyp/core.gypi
File gyp/core.gypi (right):

https://codereview.chromium.org/1392833005/diff/40001/gyp/core.gypi#newcode144
gyp/core.gypi:144: '<(skia_src_path)/core/SkLineClipper.cpp',
No matching .h ?

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
File src/core/SkLocalMatrixImageFilter.cpp (right):

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:22: if (localM.isIdentity()) {
readd this ?

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:46: 
use SkMatrix::Concat ?

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:67: Context localCtx(concat(ctx.ctm(),
fLocalM), ctx.clipBounds(), ctx.cache());
this-> on the getInputs ?

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:72: SkIRect* dst) const {
this-> here too ?

[Stephen White, 2015-10-13 20:10:46]

On 2015/10/13 19:32:49, reed1 wrote:
> BTW -- (perhaps later) I bet we could query the base filter to see if it is
> affected by a given local-matrix. If it is not, we could more aggressively use
> the SkRef(this) case in the factory. (e.g. many filters seem unaffected by
> translate in the matrix).

Great idea. I think the best way to do this would be a usesCTM() traversal, a la
usesSrcInput().

Log a bug?

[Stephen White, 2015-10-13 20:12:39]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-10-13 20:12:40]

I've massaged this to look more like SkImageFilter::CreateMatrixFilter().

https://codereview.chromium.org/1392833005/diff/40001/gyp/core.gypi
File gyp/core.gypi (right):

https://codereview.chromium.org/1392833005/diff/40001/gyp/core.gypi#newcode144
gyp/core.gypi:144: '<(skia_src_path)/core/SkLineClipper.cpp',
On 2015/10/13 19:42:39, robertphillips wrote:
> No matching .h ?

Done.

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
File src/core/SkLocalMatrixImageFilter.cpp (right):

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:22: if (localM.isIdentity()) {
On 2015/10/13 19:42:39, robertphillips wrote:
> readd this ?

Done.

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:46: 
On 2015/10/13 19:42:39, robertphillips wrote:
> use SkMatrix::Concat ?

Done.

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:67: Context localCtx(concat(ctx.ctm(),
fLocalM), ctx.clipBounds(), ctx.cache());
On 2015/10/13 19:42:39, robertphillips wrote:
> this-> on the getInputs ?

Done.

https://codereview.chromium.org/1392833005/diff/40001/src/core/SkLocalMatrixI...
src/core/SkLocalMatrixImageFilter.cpp:72: SkIRect* dst) const {
On 2015/10/13 19:42:39, robertphillips wrote:
> this-> here too ?

Done.

[Stephen White, 2015-10-13 20:27:57]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-13 20:28:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392833005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392833005/140001

[commit-bot: I haz the power, 2015-10-13 20:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 20:28:59]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[Stephen White, 2015-10-13 20:29:37]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-13 20:29:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392833005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392833005/160001

[commit-bot: I haz the power, 2015-10-13 20:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 20:37:04]

Dry run: This issue passed the CQ dry run.

[reed2, 2015-10-14 00:45:35]

reed@chromium.org changed reviewers:
+ reed@chromium.org

[reed2, 2015-10-14 00:45:36]

I think I prefer not creating the separate header-file when its not needed, but
I'm fine to land this as is.

[Stephen White, 2015-10-14 11:52:30]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-10-14 11:52:31]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1392833005/#ps160001
(title: "Add missing file")

[commit-bot: I haz the power, 2015-10-14 11:52:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392833005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392833005/160001

[commit-bot: I haz the power, 2015-10-14 11:53:36]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/20311d4843f25e6a3d9416456b18780ad5d9c1fa