Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 139283005: Pull new GN binary @ r247206 (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Pull new GN binary @ r247206 Additionally, the Windows binary is a debug build to help find a rare assertion failure. Updates build files to use a list which this new build requires. Update win-tool link commands to match GYP TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247408

Patch Set 1 #

Patch Set 2 : Fix skia #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/win/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/bin/linux/gn.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/linux/gn32.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/mac/gn.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/win/gn.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/net/third_party/nss/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/skia/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/139283005/1
6 years, 11 months ago (2014-01-27 08:44:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/139283005/20003
6 years, 11 months ago (2014-01-27 09:00:40 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chromedriver_unittests, components_unittests, ...
6 years, 11 months ago (2014-01-27 09:19:38 UTC) #3
brettw
Committed patchset #3 manually as r247408 (presubmit successful).
6 years, 11 months ago (2014-01-28 06:03:24 UTC) #4
scottmg
6 years, 10 months ago (2014-01-28 17:11:56 UTC) #5
Message was sent while issue was closed.
do you need to push .pdbs with the win32 binary too?

Powered by Google App Engine
This is Rietveld 408576698