Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.cc

Issue 139283003: [NaCl SDK] nacl_io: Fix inet_ntop to be consistent with glibc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.cc
diff --git a/native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.cc b/native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.cc
deleted file mode 100644
index c6cf6107dff4d74cf0dbeddf95d7bfb0148ab68e..0000000000000000000000000000000000000000
--- a/native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntoa.cc
+++ /dev/null
@@ -1,28 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "nacl_io/ossocket.h"
-#if defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__)
-
-#include <string.h>
-#include "sdk_util/macros.h"
-
-static uint8_t GetByte(const void* addr, int byte) {
- const char* buf = static_cast<const char*>(addr);
- return static_cast<uint8_t>(buf[byte]);
-}
-
-EXTERN_C_BEGIN
-
-char* inet_ntoa(struct in_addr in) {
- static char addr[INET_ADDRSTRLEN];
- snprintf(addr, INET_ADDRSTRLEN, "%u.%u.%u.%u",
- GetByte(&in, 0), GetByte(&in, 1),
- GetByte(&in, 2), GetByte(&in, 3));
- return addr;
-}
-
-EXTERN_C_END
-
-#endif // defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__)

Powered by Google App Engine
This is Rietveld 408576698