Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 1392823004: [Release] More information on how to close auto-roller (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Release] More information on how to close auto-roller If you are not logged in with your Google account you are faced with a blank screen. In order to make it more clear for the Chromium sheriffs on how to close the auto-roller I want to add this information. R=machenbach@chromium.org LOG=N NOTRY=true Committed: https://crrev.com/86c27e01e9f8627ee1187a1a327b1f4d087c9f2e Cr-Commit-Position: refs/heads/master@{#31670}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed wording #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/release/chromium_roll.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/release/test_scripts.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Hablich
PTAL Alternatively display this information on the auto-roller page instead of a blank screen.
5 years, 2 months ago (2015-10-07 15:41:53 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1392823004/diff/1/tools/release/chromium_roll.py File tools/release/chromium_roll.py (right): https://codereview.chromium.org/1392823004/diff/1/tools/release/chromium_roll.py#newcode21 tools/release/chromium_roll.py:21: This only works with your Google account.""") s/your/a ...
5 years, 2 months ago (2015-10-08 09:55:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392823004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392823004/20001
5 years, 2 months ago (2015-10-08 10:10:16 UTC) #5
Michael Achenbach
Remember to put NOTRY=true on CLs like this...
5 years, 2 months ago (2015-10-08 10:20:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392823004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392823004/20001
5 years, 1 month ago (2015-10-30 09:07:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 09:09:18 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 09:09:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86c27e01e9f8627ee1187a1a327b1f4d087c9f2e
Cr-Commit-Position: refs/heads/master@{#31670}

Powered by Google App Engine
This is Rietveld 408576698