Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1392823003: [heap] Decrease large object limit for regular heap objects. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Decrease large object limit for regular heap objects. Committed: https://crrev.com/e887d42342b3449f64fb6078f84f6c55bae3978d Cr-Commit-Position: refs/heads/master@{#31217}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M src/heap/spaces.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Hannes Payer (out of office)
5 years, 2 months ago (2015-10-12 14:53:49 UTC) #2
Michael Lippautz
lgtm
5 years, 2 months ago (2015-10-12 15:15:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392823003/20001
5 years, 2 months ago (2015-10-12 15:20:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/8650) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-12 15:21:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392823003/40001
5 years, 2 months ago (2015-10-12 16:16:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-12 16:39:18 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e887d42342b3449f64fb6078f84f6c55bae3978d Cr-Commit-Position: refs/heads/master@{#31217}
5 years, 2 months ago (2015-10-12 16:39:46 UTC) #12
Hannes Payer (out of office)
5 years, 2 months ago (2015-10-12 17:10:53 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1402823002/ by hpayer@chromium.org.

The reason for reverting is: broken tests.

Powered by Google App Engine
This is Rietveld 408576698