Issue 13928020: Update test plugins to be fat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13928020: Update test plugins to be fat. (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)

Modified:
7 years, 8 months ago

Reviewers:
Mark Mentovai, Matt Perry

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, --1 lines)			Patch
M	chrome/test/data/extensions/uitest/plugins/README	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/uitest/plugins/plugin.plugin/Contents/MacOS/TestNetscapePlugIn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/uitest/plugins_private/plugin.plugin/Contents/MacOS/TestNetscapePlugIn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 6 (0 generated)

Mark Mentovai

LGTM, although I’m not sure why this is a checked-in binary instead of something that ...

7 years, 8 months ago (2013-04-09 19:14:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13928020/1

7 years, 8 months ago (2013-04-09 19:29:05 UTC) #4

Avi (use Gerrit)

7 years, 8 months ago (2013-04-10 18:38:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r193424 (presubmit successful).