Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1392763003: [test] re-add test for SetAbortOnUncaughtExceptionCallback() API (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] re-add test for SetAbortOnUncaughtExceptionCallback() API BUG= R= LOG=N Committed: https://crrev.com/7c7d192a937334ce8e9d2c9194f57c68c872ca9b Cr-Commit-Position: refs/heads/master@{#31158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M test/cctest/test-api.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
PTAL --- I accidentally removed this test during a rebase. If any owner can rubberstamp ...
5 years, 2 months ago (2015-10-07 11:43:48 UTC) #1
caitp (gmail)
+bmeurer who reviewed the commit which landed the test before
5 years, 2 months ago (2015-10-07 13:53:47 UTC) #3
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-07 17:06:37 UTC) #4
caitp (gmail)
On 2015/10/07 17:06:37, Benedikt Meurer wrote: > lgtm Thanks!
5 years, 2 months ago (2015-10-07 17:08:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392763003/1
5 years, 2 months ago (2015-10-07 17:09:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 17:32:41 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 17:33:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c7d192a937334ce8e9d2c9194f57c68c872ca9b
Cr-Commit-Position: refs/heads/master@{#31158}

Powered by Google App Engine
This is Rietveld 408576698