Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1392763002: [Android] Add a hard reset to device_status_check. (Closed)

Created:
5 years, 2 months ago by jbudorick
Modified:
5 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a hard reset to device_status_check. Devices sometimes get in a state where any 'adb shell pm' commands or attempts to reboot via 'adb reboot' hang. This patch adds a workaround that reboots devices in that state. Tested on build1-b4, which had 2 such devices. BUG= Committed: https://crrev.com/6f3a99116bbd04be5cf978d6e55ef1be18fb2ddc Cr-Commit-Position: refs/heads/master@{#352759}

Patch Set 1 #

Patch Set 2 : better exception handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 2 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
5 years, 2 months ago (2015-10-07 01:20:06 UTC) #2
jbudorick
note that the current try job hit one such device and recovered it: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/78812
5 years, 2 months ago (2015-10-07 02:14:46 UTC) #3
ghost stip (do not use)
lgtm. assuming the purple is due to the perf_unittests timeouts
5 years, 2 months ago (2015-10-07 02:36:47 UTC) #4
jbudorick
On 2015/10/07 02:36:47, stip wrote: > lgtm. assuming the purple is due to the perf_unittests ...
5 years, 2 months ago (2015-10-07 02:41:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392763002/20001
5 years, 2 months ago (2015-10-07 02:43:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 03:43:29 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 03:44:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f3a99116bbd04be5cf978d6e55ef1be18fb2ddc
Cr-Commit-Position: refs/heads/master@{#352759}

Powered by Google App Engine
This is Rietveld 408576698