Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1392733002: Re-land "Check in a simple pure-python based Markdown previewer." (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, jam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Check in a simple pure-python based Markdown previewer." This re-lands #352450 with a fix to make checklicenses.py happy. R=thestig@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/27c171cd168807f85b95ae8aaa797bda02eff319 Cr-Commit-Position: refs/heads/master@{#352731}

Patch Set 1 : original patch #

Patch Set 2 : whitelist directory for checklicenses #

Patch Set 3 : clarify comment re: licenses, add bug #, use --no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6381 lines, -0 lines) Patch
A third_party/Python-Markdown/LICENSE.md View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/README.chromium View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/README.md View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/__init__.py View 1 2 1 chunk +529 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/__main__.py View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/__version__.py View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/blockparser.py View 1 2 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/blockprocessors.py View 1 2 1 chunk +563 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/__init__.py View 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/abbr.py View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/admonition.py View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/attr_list.py View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/codehilite.py View 1 chunk +265 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/def_list.py View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/extra.py View 1 chunk +132 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/fenced_code.py View 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/footnotes.py View 1 2 1 chunk +319 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/headerid.py View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/meta.py View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/nl2br.py View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/sane_lists.py View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/smart_strong.py View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/smarty.py View 1 chunk +263 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/tables.py View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/toc.py View 1 chunk +309 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/extensions/wikilinks.py View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/inlinepatterns.py View 1 2 1 chunk +529 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/odict.py View 1 2 1 chunk +191 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/postprocessors.py View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/preprocessors.py View 1 2 1 chunk +345 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/serializers.py View 1 2 1 chunk +282 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/treeprocessors.py View 1 2 1 chunk +371 lines, -0 lines 0 comments Download
A third_party/Python-Markdown/markdown/util.py View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A tools/md_browser/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tools/md_browser/README.md View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/md_browser/doc.css View 1 chunk +298 lines, -0 lines 0 comments Download
A tools/md_browser/footer.html View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/md_browser/header.html View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/md_browser/md_browser.py View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
@thestig - Can I get an OWNERS approval for the checklicenses change?
5 years, 2 months ago (2015-10-06 23:56:47 UTC) #1
Lei Zhang
LGTM I https://github.com/waylan/Python-Markdown/issues their bug tracker? Can you kindly ask them to fix this issue, ...
5 years, 2 months ago (2015-10-07 00:01:34 UTC) #2
Dirk Pranke
On 2015/10/07 00:01:34, Lei Zhang wrote: > LGTM > > I https://github.com/waylan/Python-Markdown/issues their bug tracker? ...
5 years, 2 months ago (2015-10-07 00:24:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392733002/60001
5 years, 2 months ago (2015-10-07 00:25:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 2 months ago (2015-10-07 00:44:49 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 00:45:41 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27c171cd168807f85b95ae8aaa797bda02eff319
Cr-Commit-Position: refs/heads/master@{#352731}

Powered by Google App Engine
This is Rietveld 408576698