Issue 139273002: Refactoring: Extract StyleSheetCandidate from DocumentStyleSheetCollection

Issue 139273002: Refactoring: Extract StyleSheetCandidate from DocumentStyleSheetCollection (Closed)

Created:
6 years, 11 months ago by Hajime Morrita

Modified:
6 years, 11 months ago

Reviewers:
tasak, dglazkov1

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactoring: Extract StyleSheetCandidate from DocumentStyleSheetCollection This change introduces StyleSheetCandidate that encapsulates difference between candidate node subclasses. TEST=none BUG=334338 R=tasak@google.com, dglazkov, tasak Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165196

Patch Set 1 #

Patch Set 2 : Fixed a crash, landing. #

Patch Set 3 : Updated to ToT #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -85 lines)			Patch
M	Source/core/core.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View		2 chunks	+22 lines, -63 lines	0 comments	Download
M	Source/core/dom/StyleEngine.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	Source/core/dom/StyleSheetCandidate.h	View		1 chunk	+38 lines, -22 lines	0 comments	Download
A	Source/core/dom/StyleSheetCandidate.cpp	View	1 2	1 chunk	+128 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/139273002/60001

6 years, 11 months ago (2014-01-15 09:33:13 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...

6 years, 11 months ago (2014-01-15 16:41:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/139273002/230001

6 years, 11 months ago (2014-01-16 01:43:06 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=22877

6 years, 11 months ago (2014-01-16 05:31:01 UTC) #6

Hajime Morrita

6 years, 11 months ago (2014-01-16 05:38:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r165196 (presubmit successful).

Expand Messages | Collapse Messages